Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stock value calculation #6935

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

mbayopanda
Copy link
Collaborator

This PR changes the order of calling the procedure ComputeStockValue so that calculation is done after stock movement.

This PR also set the stock adjustment movements to use the WAC value.

@mbayopanda mbayopanda requested a review from lomamech February 8, 2023 14:46
Copy link
Collaborator

@lomamech lomamech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can add the possibility of including Pharmacists' feedback in this PR or in another

  • If this is the case, it will be necessary that the entries coming from the integrations as well as the purchase orders can be done at the defined cost or at the cost of the supplier
  • The transfer from the source deposit must always go out at the time of purchase and be received with the same cost
  • For other deposits, the exit must be made in relation to the weighted average cost or the weighted average cost fixed in the system

@lomamech
Copy link
Collaborator

Do you think you can add the possibility of including Pharmacists' feedback in this PR or in another

  • If this is the case, it will be necessary that the entries coming from the integrations as well as the purchase orders can be done at the defined cost or at the cost of the supplier
  • The transfer from the source deposit must always go out at the time of purchase and be received with the same cost
  • For other deposits, the exit must be made in relation to the weighted average cost or the weighted average cost fixed in the system

@mbayopanda How to discuss the different points mentioned above will be treated in another Issue

@lomamech
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 10, 2023

Build succeeded:

@bors bors bot merged commit cf13a7d into Third-Culture-Software:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants