fix(build): build minifies using uglifyjs #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in which ECMAScript 6 features were used in the client, breaking `uglify`'s build. These features have been removed in favor of their ES5 alternates. The `pump` module has been added as a development dependency due to better gulp build errors. Closes #704.
jniles
force-pushed
the
bug-minify-build
branch
from
6c40cf2 to
3d40738
Compare
bors bot
added a commit
that referenced
this pull request
Oct 8, 2018
3234: Update ioredis to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [ioredis](https://github.com/luin/ioredis) was updated from `3.2.2` to `4.0.1`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v4.0.1</summary> <h3>Bug Fixes</h3> <ul> <li><strong>cluster:</strong> robust solution for pub/sub in cluster (<a href="https://urls.greenkeeper.io/luin/ioredis/issues/697">#697</a>) (<a href="https://urls.greenkeeper.io/luin/ioredis/commit/13a5bc4">13a5bc4</a>), closes <a href="https://urls.greenkeeper.io/luin/ioredis/issues/696">#696</a></li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 80 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/47ab05c28dd499a4af87a93a547d05c74aa4f5cf"><code>47ab05c</code></a> <code>chore(release): 4.0.1</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/0c8b0c6783f72d1c8b628b2099e2dc9d46210164"><code>0c8b0c6</code></a> <code>docs(CHANGELOG): 4.0.1</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/451d34372f25a36963413a54e2513eb2072f66d8"><code>451d343</code></a> <code>chore: set bump type explicitly when releasing</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/f9ec0ac5749028763e16f57dc10b713e44ef1c17"><code>f9ec0ac</code></a> <code>docs(CHANGELOG): 4.0.1</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/6050b0fa1e01e6bb201d0ac939c21d090a779c46"><code>6050b0f</code></a> <code>test: fail fast when monitor not working</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/13a5bc4097d61531f94862ab25205cac0c2e3f0c"><code>13a5bc4</code></a> <code>fix(cluster): robust solution for pub/sub in cluster (#697)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/63067c3e4c9421ec8b4507b229288c8ab2993799"><code>63067c3</code></a> <code>chore: updated package.json to require node >=6 (#705)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/cfa4e86fda6988810224719f9f40e0695cfba433"><code>cfa4e86</code></a> <code>refactor: use Buffer.from() instead of new Buffer()</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/551e67f977cda78e377dd688a1aaf7ab0f2651cf"><code>551e67f</code></a> <code>deps: bump redis-commands for Redis 5.0 commands (#692)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/bd05e534d35ce3e08c96989f8baaa870777c07b8"><code>bd05e53</code></a> <code>docs(API.md): Typo in API.md (#686)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/9d4a6d44c3412d1cea9d7bb34349de7932031f9d"><code>9d4a6d4</code></a> <code>docs(Changelog): fix syntax error in Changelog.md (#682)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/5fbe8393c8aa3eb37aa172d5bd9416df9aa4cde3"><code>5fbe839</code></a> <code>docs(CHANGELOG): add notes for major updates</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/206b0ed01215dc5ca6091ab4e017dbed21056008"><code>206b0ed</code></a> <code>docs(CHANGELOG): 4.0.0</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/e6bf95bba3923cf2bbf65b590c94dca40351edbc"><code>e6bf95b</code></a> <code>4.0.0</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/eb79e2d3851f7d0a29b413fc56d4a1a87db62ebc"><code>eb79e2d</code></a> <code>docs(README): mention duplicate keys in scan stream example (#681)</code></li> </ul> <p>There are 80 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/luin/ioredis/compare/e16cf7e296234dd65b8127e8b5fb793f406b06e8...47ab05c28dd499a4af87a93a547d05c74aa4f5cf">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in which ECMAScript 6 features were used in the client, breaking
uglify's build. These features have been removed in favor of their ES5 alternates.The
pumpmodule has been added as a development dependency due to better gulp build errors.Closes #704.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks.