chore(procedures): merge procedures into one file #7196
Conversation
There was a problem hiding this comment.
The code changes look fine. I tested it and it works.
However, please update the procedures.sql to have a separator (eg, horizontal bar) between each "file" in the procedures.sql indicating the nature of the following SQL code. For instance, if you look at line 690 or 1957 it is not clear what the description applies to. When it was in a separate file, it was obvious. But now that it is part of single file, it would be helpful to add a little header for each section with a separating line and a brief title about what the following section is about (possibly just a simple adaptation of the original SQL file name..)
Also, does anything need to be done in the SQL migration file?
|
Nothing needs to be done with the migration files. I'll add in the requested changes this week. 👍 . I agree it would make it nicer. |
jniles
force-pushed
the
7188-merge-stored-procedures-into-single-file
branch
from
689e0d9 to
6ed5ba5
Compare
|
@jmcameron I believe the changes have been made! |
This commit merges all the procedures into a single file, and deletes the old procedures/*.sql files. It also removes references to the different procedure files in our build steps. Closes Third-Culture-Software#7188.
Adds better section headings to the procedures file.
jniles
force-pushed
the
7188-merge-stored-procedures-into-single-file
branch
from
c22df40 to
8d1b1ad
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This commit merges all the procedures into a single file, and deletes the old procedures/*.sql files. It also removes references to the different procedure files in our build steps.
Closes #7188.
This PR does not necessarily mean we need to go this direction the project maintainers do not wish to. It would just make things a bit easier when it comes to builds and deployment (though maybe increase in difficulty to maintenance).