Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(purchase): checks for missing PO creation #7197

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Aug 13, 2023

This commit adds in checks to ensure that all purchase orders successfully send 201 status checks for creation.

Closes #7192.

This commit adds in checks to ensure that all purchase orders
successfully send 201 status checks for creation.

Closes Third-Culture-Software#7192.
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested it and it works fine.

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 5cfee65 into Third-Culture-Software:master Aug 14, 2023
@jniles jniles deleted the 7192-fix-checks-for-purchase-order-creation-tests branch August 14, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purchase creation tests do not check for success in creation of purchase orders
2 participants