Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payroll): add service to multiple payroll #7198

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Aug 13, 2023

Adds the service column to the multiple payroll to allow managers to see which services have paid their staff on time. It also adds it to the multiple payroll index page.

Multiple Payroll
image

Multiple Payroll Index
image

Closes #7124.

Adds the service column to the multiple payroll to allow managers to see
which services have paid their staff on time.  It also adds the service
name to the multiple payroll indice page.

Closes Third-Culture-Software#7124.
@jniles jniles force-pushed the 7124-add-service-column-to-multipayroll branch from 890a5d7 to 7ae630e Compare August 13, 2023 15:20
@jniles jniles requested review from jmcameron and mbayopanda August 13, 2023 15:21
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
I tested this (sort-of) and it seems to work.
I also did a test merge with PR 7159 (HGR payroll) and there were no merge problems so it does not matter whether this is merged before the HGR payroll PR.

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 201667f into Third-Culture-Software:master Aug 14, 2023
@jniles jniles deleted the 7124-add-service-column-to-multipayroll branch August 14, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Service" column to the Multiple Payroll Registry
2 participants