feature(Set Is Medical from Employee Jobtitle) #7227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcameron
reviewed
Aug 28, 2023
There was a problem hiding this comment.
The code changes look okay.
I tested it with bhima_test and would like two fixes:
- In the employee registry when I try to do a search by "Job Title", it does not work.
- Please update the employee registry to it remembers the column selections. Currently it forgets the column selections every time you leave the page.
I did not test this by doing a payroll. I encourage you to verify that the payroll process works correctly with this change.
- Remove property is_medical from Employee - Add property is_medical in table title_employee - Update modules closes Third-Culture-Software#7170
… placeholder message
- Fix error and bug on component Employee Job title select
lomamech
force-pushed
the
setIsMedicalFromEmpleyeeJobTitle
branch
from
6d7f4b1 to
16e513c
Compare
jmcameron
approved these changes
Aug 29, 2023
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7170.