Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove protractor tests #7229

Merged

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Aug 26, 2023

This PR wraps up the saga of protractor as our end to end test
framework. It removes all the protractor code in favor of playwright.
Thanks to @jmcameron for all his hard work to make this possible.

Closes #7218.

jniles added 2 commits August 26, 2023 13:53
This commit wraps up the saga of protractor as our end to end test
framework.  It removes all the protractor code in favor of playwright.
Thanks to @jmcameron for all his hard work to make this possible.

Closes Third-Culture-Software#7218.
Renames the playwright tests to remove the word "playwright".
@jniles jniles changed the title 7218 remove protractor tests Remove protractor tests Aug 26, 2023
@mbayopanda
Copy link
Collaborator

@jniles can you resolve conflicts so that I can merge this PR? Thanks

Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I've tested it and it seems to work correctly.

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 920af55 into Third-Culture-Software:master Aug 28, 2023
@jniles jniles deleted the 7218-remove-protractor-tests branch August 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean out old Protractor E2E tests
3 participants