Speed up /stock/lots/depot query

[jmcameron]

Refactored the filtering for user permissions speed up the lot queries. The lots routes that use these function getLots(), getAssets(), and getLotsDepot() were using the following filter definition (in getLotFilters()):

// depot permission check
filters.custom(
  'check_user_id',
  `d.uuid IN (
    SELECT DISTINCT d.depot_uuid
      FROM (
        SELECT dp.depot_uuid, dp.user_id FROM depot_permission AS dp
        UNION
        SELECT ds.depot_uuid, ds.user_id FROM depot_supervision AS ds
      ) AS d
    WHERE d.user_id = ?
  )`,
);

This means that this 'SELECT DISTINCT' query and subquery were being executed for each row of the results. This is the primary cause of the slow performance of the /stock/lots/depot endpoint with large databases.

This PR changes the above filter to run the 'SELECT DISTINCT' query once and then encodes all of the allowable depots in a new custom filter, so that each row of the results is simply doing checking to see if the depot UUID is a predefined list of UUIDs, which is much more efficient than multiple subqueries.

TESTING

• Use a large production database
• First, try this in 'master': check the time required for: Stock > Lots
• Switch to this PR and try it again and notice the speed up.\
• Verify it works with paging, use the following API endpoint:
  /stock/lots/depots?includeEmptyLot=1&limit=1000&period=allTime&paging=true&page=2

NOTE: This could be generalized by extending filterParser with an additional filter that would do a query first and then define a custom filter based on the output.

[mbayopanda]

LGTM 👍🏽

[mbayopanda]

👍🏽

[mbayopanda]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• ci/semaphoreci/push: Integration Tests