Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lots): remove incorrect header #7303

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Oct 18, 2023

This commit removes the unnecessary and incorrect header on the stock lots registry.

Closes #7294.

Screenshot:
Screenshot 2023-10-17 at 9 27 08 PM

This commit removes the unnecessary and incorrect header on the stock
lots registry.

Closes Third-Culture-Software#7294.
@jniles jniles added the Bug Fix label Oct 18, 2023
@jniles jniles requested a review from jmcameron October 18, 2023 02:28
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good.
I did not notice this problem on master with bhima_test, but the change seems appropriate.

<div class="ui-grid-cell-contents" ng-if="!row.groupHeader" translate>{{ row.entity.unit_type }}</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 18, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 1b252c5 into Third-Culture-Software:master Oct 18, 2023
@jniles jniles deleted the 7294-fix-stock-lots-registry-headers branch October 18, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The headers on stock lots "unit" column are unnecessary
2 participants