feature(Budget) #7435
Merged
feature(Budget) #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcameron
requested changes
Jan 25, 2024
There was a problem hiding this comment.
These changes look fine. However, since only accounts with a.locked=0 are permitted, there is no need to for 'acctLocked' on line 96 of index.js. So please remove it.
BTW, github updated your Pull Request, so be sure to do git pull in your local branch before making changes.
lomamech
force-pushed
the
improveBudgetModules
branch
from
8f3158d to
fca490a
Compare
- exclude locked accounts in the budget management module closes Third-Culture-Software#7434
lomamech
force-pushed
the
improveBudgetModules
branch
from
fca490a to
7cfb8ec
Compare
jmcameron
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
The code looks good.
The tests pass.
I tested this in the browser and it works.
I even modified the CSV file to include a locked account. The budget for the locked account was imported, although it was not displayed in the Budget page. So this is an unusual case that should be resolved in the future. I'll add an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7434