added docs update #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Um, sorry, this got already merged, see Codeception#28 BTW: I didn't get a notification from GitHub about this yesterday :-( |
Author
|
@ThomasLandauer don't worry, I'll present this same PR based on the master branch. |
Owner
|
OK, thanks, I'm deleting the |
ghost
deleted the
ThomasLandauer
added a commit
that referenced
this pull request
Sep 8, 2022
The line `use JsonSerializable;` of this file is not being passed on to `tests/Support/_generated/AcceptanceTesterActions.php`. And with the current phpDoc ```php @param array|string|JsonSerializable $params ``` ... phpstan is correctly reporting: > Parameter #2 $params of method Tests\Support\AcceptanceTester::sendPatch() expects array|string|Tests\Support\_generated\JsonSerializable ... So the question is: Is there a way to include the needed `use`s in the generated `TesterAction`s` Or should all occurrences of such "root" classes in the code get prefixed with a `\`?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i just run
robo build:docson this.