Skip to content

Commit bc73903

Browse files
authored
Merge pull request #1 from simon-graham/master
Upgrade to Python 3.8
2 parents a968b40 + cce4e36 commit bc73903

File tree

8 files changed

+23
-11
lines changed

8 files changed

+23
-11
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,9 +239,9 @@ support old operating systems then choose the v31 release.
239239

240240
OS | Py2 | Py3 | 32bit | 64bit | Requirements
241241
--- | --- | --- | --- | --- | ---
242-
Windows | 2.7 | 3.4 / 3.5 / 3.6 / 3.7 | Yes | Yes | Windows 7+
243-
Linux | 2.7 | 3.4 / 3.5 / 3.6 / 3.7 | Yes | Yes | Debian 8+, Ubuntu 14.04+, Fedora 24+, openSUSE 13.3+
244-
Mac | 2.7 | 3.4 / 3.5 / 3.6 / 3.7 | No | Yes | MacOS 10.9+
242+
Windows | 2.7 | 3.4 / 3.5 / 3.6 / 3.7 / 3.8 | Yes | Yes | Windows 7+
243+
Linux | 2.7 | 3.4 / 3.5 / 3.6 / 3.7 / 3.8 | Yes | Yes | Debian 8+, Ubuntu 14.04+, Fedora 24+, openSUSE 13.3+
244+
Mac | 2.7 | 3.4 / 3.5 / 3.6 / 3.7 / 3.8 | No | Yes | MacOS 10.9+
245245

246246
These platforms are not supported yet:
247247
- ARM - see [Issue #267](../../issues/267)

src/common/cefpython_public_api.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
#include "../../build/build_cefpython/cefpython_py36_fixed.h"
4747
#elif PY_MINOR_VERSION == 7
4848
#include "../../build/build_cefpython/cefpython_py37_fixed.h"
49+
#elif PY_MINOR_VERSION == 8
50+
#include "../../build/build_cefpython/cefpython_py38_fixed.h"
4951
#endif // PY_MINOR_VERSION
5052
#endif // PY_MAJOR_VERSION
5153

tools/automate.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def setup_options(docopt_args):
171171
if hasattr(Options, key2) and value is not None:
172172
setattr(Options, key2, value)
173173

174-
Options.tools_dir = os.path.dirname(os.path.realpath(__file__))
174+
Options.tools_dir = os.path.dirname(os.path.abspath(__file__))
175175
Options.cefpython_dir = os.path.dirname(Options.tools_dir)
176176

177177
if not Options.cef_git_url:
@@ -199,7 +199,7 @@ def setup_options(docopt_args):
199199

200200
# --build-dir
201201
if Options.build_dir:
202-
Options.build_dir = os.path.realpath(Options.build_dir)
202+
Options.build_dir = os.path.abspath(Options.build_dir)
203203
else:
204204
Options.build_dir = os.path.join(Options.cefpython_dir, "build")
205205
if " " in Options.build_dir:
@@ -211,7 +211,7 @@ def setup_options(docopt_args):
211211

212212
# --cef-build-dir
213213
if Options.cef_build_dir:
214-
Options.cef_build_dir = os.path.realpath(Options.cef_build_dir)
214+
Options.cef_build_dir = os.path.abspath(Options.cef_build_dir)
215215
else:
216216
Options.cef_build_dir = Options.build_dir
217217
if " " in Options.cef_build_dir:
@@ -714,7 +714,7 @@ def prepare_build_command(build_lib=False, vcvars=None):
714714
command.append(VS_PLATFORM_ARG)
715715
else:
716716
if int(Options.cef_branch) >= 2704:
717-
command.append(VS2015_VCVARS)
717+
command.append(VS2019_VCVARS)
718718
else:
719719
command.append(VS2013_VCVARS)
720720
command.append(VS_PLATFORM_ARG)
@@ -893,7 +893,7 @@ def copy_app(app):
893893

894894
def get_available_python_compilers():
895895
all_python_compilers = OrderedDict([
896-
("2015", VS2015_VCVARS),
896+
("2019", VS2019_VCVARS),
897897
])
898898
ret_compilers = OrderedDict()
899899
for msvs in all_python_compilers:

tools/build_distrib.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
ALLOW_PARTIAL = False
8080

8181
# Python versions
82-
SUPPORTED_PYTHON_VERSIONS = [(2, 7), (3, 4), (3, 5), (3, 6), (3, 7)]
82+
SUPPORTED_PYTHON_VERSIONS = [(2, 7), (3, 4), (3, 5), (3, 6), (3, 7), (3, 8)]
8383

8484
# Python search paths. It will use first Python found for specific version.
8585
# Supports replacement of one environment variable in path eg.: %ENV_KEY%.
@@ -613,7 +613,7 @@ def check_cpp_extension_dependencies_issue359(setup_dir, all_pythons):
613613
return
614614
checked_any = False
615615
for python in all_pythons:
616-
if python["version2"] in ((3, 5), (3, 6), (3, 7)):
616+
if python["version2"] in ((3, 5), (3, 6), (3, 7), (3, 8)):
617617
checked_any = True
618618
if not os.path.exists(os.path.join(setup_dir, "cefpython3",
619619
"msvcp140.dll")):

tools/common.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,9 @@
219219

220220
VS_PLATFORM_ARG = "x86" if ARCH32 else "amd64"
221221

222+
VS2019_VCVARS = ("C:\\Program Files (x86)\\Microsoft Visual Studio\\2019"
223+
"\\Professional\\VC\\Auxiliary\\Build\\vcvarsall.bat")
224+
222225
VS2015_VCVARS = ("C:\\Program Files (x86)\\Microsoft Visual Studio 14.0"
223226
"\\VC\\vcvarsall.bat")
224227

@@ -477,6 +480,8 @@ def get_msvs_for_python(vs_prefix=False):
477480
return "VS2015" if vs_prefix else "2015"
478481
elif sys.version_info[:2] == (3, 7):
479482
return "VS2015" if vs_prefix else "2015"
483+
elif sys.version_info[:2] == (3, 8):
484+
return "VS2019" if vs_prefix else "2019"
480485
else:
481486
print("ERROR: This version of Python is not supported")
482487
sys.exit(1)

tools/installer/cefpython3.__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,8 @@
6060
elif sys.version_info[:2] == (3, 7):
6161
# noinspection PyUnresolvedReferences
6262
from . import cefpython_py37 as cefpython
63+
elif sys.version_info[:2] == (3, 8):
64+
# noinspection PyUnresolvedReferences
65+
from . import cefpython_py38 as cefpython
6366
else:
6467
raise Exception("Python version not supported: " + sys.version)

tools/installer/cefpython3.setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ def main():
148148
"Programming Language :: Python :: 3.5",
149149
"Programming Language :: Python :: 3.6",
150150
"Programming Language :: Python :: 3.7",
151+
"Programming Language :: Python :: 3.8",
151152
"Topic :: Desktop Environment",
152153
"Topic :: Internet",
153154
"Topic :: Internet :: WWW/HTTP",

tools/make_installer.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,8 @@ def copy_cpp_extension_dependencies_issue359(pkg_dir):
368368
# Python 3.5 / 3.6 / 3.7
369369
if os.path.exists(os.path.join(pkg_dir, "cefpython_py35.pyd")) \
370370
or os.path.exists(os.path.join(pkg_dir, "cefpython_py36.pyd")) \
371-
or os.path.exists(os.path.join(pkg_dir, "cefpython_py37.pyd")):
371+
or os.path.exists(os.path.join(pkg_dir, "cefpython_py37.pyd")) \
372+
or os.path.exists(os.path.join(pkg_dir, "cefpython_py38.pyd")):
372373
search_paths = [
373374
# This is where Microsoft Visual C++ 2015 Update 3 installs
374375
# (14.00.24212).

0 commit comments

Comments
 (0)