Upgrade to Python 3.8 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-graham
commented
Nov 26, 2020
| setattr(Options, key2, value) | ||
|
|
||
| Options.tools_dir = os.path.dirname(os.path.realpath(__file__)) | ||
| Options.tools_dir = os.path.dirname(os.path.abspath(__file__)) |
Author
There was a problem hiding this comment.
The behaviour of realpath on Windows changed in Python 3.8. When building on a subst-ed drive, it works out the real path on the original drive and folder. This was breaking our subst-ed build_scripts build. Changing to abspath resolves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream cefpython still doesn't support Python 3.8. However there is an open PR for it: cztomczak#546. I've incorporated bits of that here, plus a few more additions.