Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Incorporating SV Expanded Crops #71

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

craw-fish
Copy link

Added crops from Stardew Valley Expanded (see Wiki page) to crops.js and data.js. Also added their icons to the img folder.

Added Spring Crops
Added Spring Crops
Added Summer, Fall, and Winter crops
Added SVE crop icons
@craw-fish
Copy link
Author

Ideally, it would be useful to add a checkbox to the calculator for enabling SVE crops. That way, these additions can be merged with the main project fairly seamlessly. However, javascript is a bit outside my comfort zone and that may be a bit too complex for me. If anyone wants to take a crack at, though, feel free!

(For now, of course, SVE users can simply download this fork and open the index.html file -- I haven't encountered any issues/typos yet)

@craw-fish craw-fish marked this pull request as draft May 16, 2024 03:50
@Thorinair
Copy link
Owner

I feel like adding support for a mod would be pushing it a bit too much. Having to edit both databases, and having to account for a mod that I don't even play with sounds like too much work in the long run and would result in me having to spend way too much energy on two things at once... Unless this mod pretty much never updates? If that is the case, I could implement it.

@craw-fish
Copy link
Author

SVE does get regular updates in general, but the additional crops are not a main focus. There are a total of 8 crops in the mod, all implemented over the course of 2 updates. AFAIK they haven't really been modified since those releases, and I wouldn't anticipate any major crop additions coming soon. So I think it would mostly be a "set it and forget it" kind of deal. But ofc I get it that's more than you're willing to deal with--just thought I'd throw it out there at least.

@doodlebunnyhops
Copy link
Contributor

hmm, what about an option for users to load in their own config?

I do agree though, even as a SVE player myself, I'd rather maintain Stardew Profits as vanilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants