Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prediction Model + Fixes #79 #80

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

doodlebunnyhops
Copy link
Contributor

@doodlebunnyhops doodlebunnyhops commented Jul 8, 2024

Refer to issue #79

Updated/Added

  • New "Use Prediction Model" button.
    • Predict Extra Crops
    • Predict number of crops by quality.
  • Apply crop quality to excess sold.
    • Assumes normal quality will be used first for seed or artisan consumption first.

Minor Bug Fixes

  • Wrong value of keg price shown, applied value was proper.
  • Tiller incorrectly applying if left checked when changing Farming Level below 5.

To Do

  • Keg and Jar prediction model not working
  • Coffee Bean in keg/jar not calculating
  • Validate NextYear in prediction model

@doodlebunnyhops doodlebunnyhops changed the title resolves Thorinair/Stardew-Profits#79 Resolves #79 Jul 8, 2024
@doodlebunnyhops doodlebunnyhops changed the title Resolves #79 Prediction Model + Fixes #79 Jul 8, 2024
@Thorinair
Copy link
Owner

Thorinair commented Jul 10, 2024

This is quite a wild one! Crazy work there!
I will get back to this next week or so when I have a bit more time to properly have a look at the code!

@doodlebunnyhops
Copy link
Contributor Author

This is quite a wild one! Crazy work there! I will get back to this next week or so when I have a bit more time to properly have a look at the code!

😅 yea to be fair here I didn't care for how the code worked out in my eyes it's a lot harder to read the flow of what's happening and I still have a couple of things to fix but put a pause (work) and also wanted input if this should be done and continue on or not.

@Thorinair
Copy link
Owner

This is quite a wild one! Crazy work there! I will get back to this next week or so when I have a bit more time to properly have a look at the code!

😅 yea to be fair here I didn't care for how the code worked out in my eyes it's a lot harder to read the flow of what's happening and I still have a couple of things to fix but put a pause (work) and also wanted input if this should be done and continue on or not.

I think that it is a great idea, and definitely something that will contribute to the functionality a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants