fix/rebalancing #30
Merged
fix/rebalancing #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldinugroho24
approved these changes
Nov 27, 2023
yangyangrusli
approved these changes
Nov 27, 2023
|
we're facing the same issue, waiting this PR to be merged |
|
+1 here |
pkg/kafka/subscriber.go
Outdated
| @@ -578,6 +581,9 @@ ResendLoop: | |||
| case <-ctx.Done(): | |||
| h.logger.Trace("Closing, ctx cancelled before sent to consumer", receivedMsgLogFields) | |||
| return nil | |||
| case <-sessionContext.Done(): | |||
There was a problem hiding this comment.
won't this fail since sess is nil?
There was a problem hiding this comment.
Session can't be nil. Saram won't start consuming in such case. By the way sarama does the same check before consuming starts, but if rebalancing started after, during processing messages, it hangs on trying commit offset with staled session.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks. I've overlooked it. Fixed this.
|
Thank you for the contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking that the session context has been canceled. If this is not done, after rebalancing consumer will continue to work, but offset will not be able to commit because of error: