-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io.Writer and io.Reader pubsub. Also, CLI tool for watermill #53
Conversation
dev/cli/cmd/root.go
Outdated
"github.com/spf13/viper" | ||
) | ||
|
||
var random = rand.New(rand.NewSource(time.Now().Unix())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random
is unused (from varcheck
)
return p.wc.Close() | ||
} | ||
|
||
func (p Publisher) write(topic string, msg *message.Message) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write passes lock by value: github.com/ThreeDotsLabs/watermill/message/infrastructure/io.Publisher contains sync.WaitGroup contains sync.noCopy (from govet
)
s.config.Logger.Trace("Reader channel closed", nil) | ||
} | ||
|
||
func (s Subscriber) read(reader *bufio.Reader) chan []byte { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read passes lock by value: github.com/ThreeDotsLabs/watermill/message/infrastructure/io.Subscriber contains sync.WaitGroup contains sync.noCopy (from govet
)
No description provided.