Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused fields #1209

Closed
wants to merge 2 commits into from
Closed

Remove unused fields #1209

wants to merge 2 commits into from

Conversation

AnthonySteele
Copy link
Contributor

@AnthonySteele AnthonySteele commented Apr 21, 2020 •
edited
Loading

Fixes / New Feature #

Proposed Changes

Remove unused fields that are causing compiler warnings.

Similar to #1208
but a different warning, this time with e.g.

Warning	CS0169	
The field 'ReasonPhraseTests._contentLength' is never used	
Ocelot.AcceptanceTests	C:\code\Ocelot\test\Ocelot.AcceptanceTests\ReasonPhraseTests.cs	15

Remove unused fields
bd8789c 
Causing compiler warnings
@raman-m raman-m changed the base branch from master to develop July 19, 2023 20:30
@raman-m
Copy link
Member

raman-m commented Jul 19, 2023

Thanks for the PR!

After merging of develop to your feature branch the changes disappeared.
Strange!
It seems the same changes are already presented in develop branch.
Right?

And two files of tests in diff have zero changes too...

What to do with your PR?
It seems it is not relevant anymore.

@raman-m raman-m added question Initially seen a question could become a new feature or bug or closed ;) wontfix No plan to include this issue in the Ocelot core functionality. waiting Waiting for answer to question or feedback from issue raiser labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AnthonySteele AnthonySteele

Labels
question Initially seen a question could become a new feature or bug or closed ;) waiting Waiting for answer to question or feedback from issue raiser wontfix No plan to include this issue in the Ocelot core functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonySteele @raman-m