-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override the ClaimsToHeadersMiddleware
by the OcelotPipelineConfiguration
settings
#1403
Override the ClaimsToHeadersMiddleware
by the OcelotPipelineConfiguration
settings
#1403
Conversation
@kesskalli Hi Karim! 3 years have been passed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are not covered by unit and acceptance tests!
Let's collaborate on writing tests...
3fd2d08
to
ab2d12c
Compare
@kesskalli Hi Karim! I see that develop branch in your fork is old! |
@kesskalli commented on Dec 28, 2020:
I see these changes. The community will review them soon.
Yeah, but in theory. And I don't see these changes in files. Also, don't forget to write tests please! Is this PR related to an issue in backlog? |
ab2d12c
to
8e88acb
Compare
OcelotPipelineConfiguration
settings
OcelotPipelineConfiguration
settingsClaimsToHeadersMiddleware
by the OcelotPipelineConfiguration
settings
New Feature
The idea is to allow to use custom claims to headers transformation logic after the authorization process is done.
The transformation using a JSON file requires to handle everything by route. The file will become very verbose in this case.
In some cases, the internal HTTP services can expect some HTTP "X-" Headers to get more context about the request (to support multi-tenancy for instance), the override will allow to add them automatically.
Proposed Changes