#2078 V7 polly syntax not longer supported #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynaldM
added
small effort
|
Next time, could you create feature branch in your personal folder like: |
raman-m
approved these changes
May 29, 2024
Comment on lines
-57
to
-59
| Important changes in version `23.2`_: [#f3]_ | ||
|
|
||
| - With `Polly`_ version 8+, the ``ExceptionsAllowedBeforeBreaking`` value must be equal to or greater than **2**! |
There was a problem hiding this comment.
I believe these lines can be retained and relocated to an earlier position.
| @@ -34,7 +34,7 @@ | |||
| <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.507"> | |||
| <PrivateAssets>all</PrivateAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="Polly" Version="8.3.1" /> | |||
| <PackageReference Include="Polly" Version="8.4.0" /> | |||
There was a problem hiding this comment.
Right! Good to bump the version!
| @@ -112,96 +111,4 @@ public static IOcelotBuilder AddPolly(this IOcelotBuilder builder) | |||
| /// <returns>A <see cref="DelegatingHandler"/> object, but concrete type is the <see cref="PollyResiliencePipelineDelegatingHandler"/> class.</returns> | |||
| private static DelegatingHandler GetDelegatingHandler(DownstreamRoute route, IHttpContextAccessor contextAccessor, IOcelotLoggerFactory loggerFactory) | |||
| => new PollyResiliencePipelineDelegatingHandler(route, contextAccessor, loggerFactory); | |||
|
|
|||
| #region Obsolete extensions will be removed in future version | |||
There was a problem hiding this comment.
I love when regions are removed 😃
| @@ -75,7 +75,7 @@ | |||
| <PackageReference Include="CacheManager.Core" Version="2.0.0-beta-1629" /> | |||
| <PackageReference Include="CacheManager.Microsoft.Extensions.Configuration" Version="2.0.0-beta-1629" /> | |||
| <PackageReference Include="CacheManager.Microsoft.Extensions.Logging" Version="2.0.0-beta-1629" /> | |||
| <PackageReference Include="Polly" Version="8.3.1" /> | |||
| <PackageReference Include="Polly" Version="8.4.0" /> | |||
There was a problem hiding this comment.
I'm not sure but the reference should be auto-restored because of ref to Ocelot, right?
|
I believe we could deliver it as a part of 23.3 |
Consolidate all notes into the Notes section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of AddPollyV7 and all subsequent code.
Removal of AddPollyV7 tests