add a security module （#628） #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomPallister
requested changes
Sep 21, 2018
There was a problem hiding this comment.
This is a really good PR, thank you for this! :)
In order to merge this the code needs to build and can you add unit tests for the new functionality plus acceptance tests to prove it works overall? I think we can have one that allows the IP and one that doesnt.
|
Security protection extension for Ocelot AuthorizationToken |
very cool :D |
TomPallister
approved these changes
Sep 25, 2018
|
@aqa510415008 thank you for the tests, this is very good. I have merged it now. |
1 similar comment
|
@aqa510415008 thank you for the tests, this is very good. I have merged it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #628
Add security mechanisms, IP whitelists, blacklists, and extended security interfaces.
Extend security by implementing
ISecurityPolicy@TomPallister Evaluation is feasible, feasible, I add unit test