Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize commands #509

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Modernize commands #509

merged 3 commits into from
Jul 31, 2020

Conversation

stopfstedt
Copy link
Collaborator

@stopfstedt stopfstedt commented Jul 31, 2020

  • update to latest supported console component dependency.
  • use dependency injection over container awareness.
  • future-proof execute() methods with return values.

refs #414

dependabot-preview bot and others added 3 commits July 31, 2020 04:38
ensure forward-compat by adding return value to execute methods.
remove container awareness and use DI instead where possible.
@stopfstedt stopfstedt merged commit f7ed639 into ThronesDB:master Jul 31, 2020
@stopfstedt stopfstedt deleted the modernize_commands branch July 31, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant