Fixed bug "Fresh install could prevent addon from loading when MTSLUI…

…_PLAYER is not yet loaded/filled"
Thumbkin · Jun 8, 2021 · beb8107 · beb8107
1 parent 26c9915
commit beb8107
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -46,13 +46,16 @@ Minimap button & Enhanced tooltip
 
 ### Latest version (v2.5.05)
 
-* Added missing "expansion" number for classic specialisations
-* Added some missing NPCs
-* Updated professions to only have the correct auto learned spells
-* Set the correct phase for some skill
-* Fixed bug with data not showing mobs anymore that drop an item
+* Fixed data
+  * Added missing "expansion" number for classic specialisations
+  * Added some missing NPCs
+  * Updated professions to only have the correct auto learned spells
+  * Set the correct phase for some skill
 * Added code to save ids when data is missing for an object for easier missing data reports. Include the contents of "MTSL_MISSING_DATA" from saved variables to bug report if not empty
-* fixed missing icon for Jewelcrafting in skill list frame
+* Fixed bugs
+  * Fresh install could prevent addon from loading when MTSLUI_PLAYER is not yet loaded/filled
+  * Mob data is once again shown when the item they drop is selected
+  * Missing icon for Jewelcrafting in skill list frame
 
 ### Support
 

diff --git a/VERSION_HISTORY.md b/VERSION_HISTORY.md
@@ -2,13 +2,16 @@
 
 ### v2.5.05 (June 8, 2021)
 
-* Added missing "expansion" number for classic specialisations
-* Added some missing NPCs
-* Updated professions to only have the correct auto learned spells
-* Set the correct phase for some skill
-* Fixed bug with data not showing mobs anymore that drop an item
+* Fixed data
+  * Added missing "expansion" number for classic specialisations
+  * Added some missing NPCs
+  * Updated professions to only have the correct auto learned spells
+  * Set the correct phase for some skill
 * Added code to save ids when data is missing for an object for easier missing data reports. Include the contents of "MTSL_MISSING_DATA" from saved variables to bug report if not empty
-* fixed missing icon for Jewelcrafting in skill list frame
+* Fixed bugs
+  * Fresh install could prevent addon from loading when MTSLUI_PLAYER is not yet loaded/filled
+  * Mob data is once again shown when the item they drop is selected
+  * Missing icon for Jewelcrafting in skill list frame
 
 ### v2.5.04 (June 8, 2021)
 * Added loads of spells/items/npcs for all professions

diff --git a/logic/player_npc.lua b/logic/player_npc.lua
@@ -61,10 +61,6 @@ MTSL_LOGIC_PLAYER_NPC = {
             MTSL_TOOLS:SortArray(MTSL_PLAYERS)
             MTSL_TOOLS:SortArrayByProperty(MTSL_PLAYERS[realm], "name")
         else
-            if MTSLUI_SAVED_VARIABLES:GetShowWelcomeMessage() == 1 then
-                print(MTSLUI_FONTS.COLORS.TEXT.SUCCESS .. "MTSL: " .. current_player.NAME .. " (" .. current_player.XP_LEVEL .. ", " .. current_player.FACTION .. ") on " .. current_player.REALM .. " loaded")
-            end
-
             -- set the loaded or created player as current one
             MTSL_CURRENT_PLAYER = current_player
             -- Update class, faction & xp_level, just in case

diff --git a/ui/event_handler.lua b/ui/event_handler.lua
@@ -50,6 +50,10 @@ MTSLUI_EVENT_HANDLER = {
 						print(MTSLUI_FONTS.COLORS.TEXT.TITLE .."MTSL: Using data for phase " .. MTSL_DATA.CURRENT_PATCH_LEVEL .. " (" .. MTSL_LOGIC_WORLD:GetZoneNameById(MTSL_DATA.PHASE_IDS[MTSL_DATA.CURRENT_PATCH_LEVEL]) .. ")")
 					end
 
+					if not MTSLUI_SAVED_VARIABLES or MTSLUI_SAVED_VARIABLES:GetShowWelcomeMessage() == 1 then
+						print(MTSLUI_FONTS.COLORS.TEXT.SUCCESS .. "MTSL: " .. MTSL_CURRENT_PLAYER.NAME .. " (" .. MTSL_CURRENT_PLAYER.XP_LEVEL .. ", " .. MTSL_CURRENT_PLAYER.FACTION .. ") on " .. MTSL_CURRENT_PLAYER.REALM .. " loaded")
+					end
+
 					self.addon_loaded = 1
 				end
 			else