makeshift doc-action fix #106
Conversation
| @@ -10,8 +10,10 @@ makedocs(sitename="FMIFlux.jl", | |||
| format = Documenter.HTML( | |||
| collapselevel = 1, | |||
| sidebar_sitename = false, | |||
| edit_link = nothing | |||
| edit_link = nothing, | |||
| size_threshold_ignore = ["examples/juliacon_2023.md"] | |||
There was a problem hiding this comment.
is it possible to ignore size for all examples in general? (because otherwise if we add more in the future, we need to track the examples in this makefile, which is error prone)
There was a problem hiding this comment.
Disabling size check (like here) is not recommended, as "svg printing" issues in might get obvious this way. Future doc improvement should implement this by setting a size limit, that is valid for all correctly rendered examples. juliacon example is still broken due to gif issue (similar to svg issue)
There was a problem hiding this comment.
disabling the size check in general is not possible
There was a problem hiding this comment.
adding a larger threshold instead?
| @@ -1,3 +1,2 @@ | |||
| params/ | |||
| *.png | |||
| *.gif | |||
There was a problem hiding this comment.
this is because some examples are generating GIFs, if they are executed locally, GIFs are saved to this path.
Please don't change this file at all. Thanks!
There was a problem hiding this comment.
and the examples render svgs. so why should we handle gifs differently than svgs? they should both be saved, right?
removed build and svg problem:
fixes for update to documenter v1
downgrade from juila 1.9 to 1.8 for svg problem