Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode is not working for components using portals #1608

Open
glenngijsberts opened this issue Sep 15, 2022 · 0 comments
Open

Dark mode is not working for components using portals #1608

glenngijsberts opened this issue Sep 15, 2022 · 0 comments
Assignees
@diogoredin @RobVermeer @bobbonius @glenngijsberts
Labels
improvement

Comments

@glenngijsberts
Copy link
Contributor

Improvement description

Components, such as Toasts and Dialogs, are not working in dark mode. This has to do with the portals that are being used, that are rendering the components outside of the root of the playground and so they don't have a parent with the data-theme="dark" property.

Expected behaviour

Portals should be either rendered inside the root, or we should find another way to make those components work in dark mode.
glenngijsberts added a commit that referenced this issue Sep 15, 2022
@glenngijsberts
feat(Toast): Make sure to use inverted colors for toast
67ede29 
Design would like to use inverted colors for our toasts, so that they
are better visible. This was already done before, and reverted, but
this was probably done because the colors weren't correctly displayed
in storybook. This is because the toasts are displayed in a portal,
and storybook is not handling them really great. Added #1608 to improve
this.
@glenngijsberts glenngijsberts mentioned this issue Sep 15, 2022
Merged
glenngijsberts added a commit that referenced this issue Sep 16, 2022
@glenngijsberts
feat(Toast): Make sure to use inverted colors for toast
e51d943 
Design would like to use inverted colors for our toasts, so that they
are better visible. This was already done before, and reverted, but
this was probably done because the colors weren't correctly displayed
in storybook. This is because the toasts are displayed in a portal,
and storybook is not handling them really great. Added #1608 to improve
this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diogoredin diogoredin

@RobVermeer RobVermeer

@bobbonius bobbonius

@glenngijsberts glenngijsberts

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@diogoredin @RobVermeer @bobbonius @glenngijsberts