Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce RadioPanel component #1792

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Introduce RadioPanel component #1792

merged 2 commits into from
Aug 31, 2023

Conversation

diogoredin
Copy link
Contributor

@diogoredin diogoredin commented Aug 29, 2023 •
edited
Loading

Description

This component creates a RadioPanel component based on the Radio button component we already have.

Changes

  • This has been done
  • I still need to to this

How to test

  • Checkout this branch
  • $ yarn dev

Screenshots

Screenshot 2023-08-30 at 17 35 51 Screenshot 2023-08-29 at 17 00 26

To be notified

@RobVermeer

@diogoredin
chore: Allow Radio button to have loading state
1c5b2bf 
In case we want to perform mutations when a radio option is selected,
we need the component to have this state.

JIRA ATLAS-3145
@diogoredin diogoredin force-pushed the diogo/ATLAS-3145-introduce-radio-panel branch from 6aa29c6 to d88bad1 Compare August 30, 2023 15:35
RobVermeer
RobVermeer reviewed Aug 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@diogoredin
feat: Introduce RadioPanel component
73fec22 
This commit introduces a RadioPanel component.

JIRA ATLAS-3145
@diogoredin diogoredin force-pushed the diogo/ATLAS-3145-introduce-radio-panel branch from d88bad1 to 73fec22 Compare August 31, 2023 07:43
@diogoredin diogoredin merged commit ebfbd16 into main Aug 31, 2023
3 checks passed
@diogoredin diogoredin deleted the diogo/ATLAS-3145-introduce-radio-panel branch August 31, 2023 07:46
@RobVermeer
Copy link
Collaborator

🎉 This PR is included in version 31.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobVermeer RobVermeer RobVermeer approved these changes

Assignees
No one assigned
Labels
first approval ready for review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogoredin @RobVermeer