Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make transaction handling compatible with node-sqlite3-wasm
https://github.com/tndrle/node-sqlite3-wasm doesn't have transaction support so I've tried to implement it using SQL statements directly. @hoelzro do you think this is right? Should we be rolling back the transaction in the finally clause? It would be nice to have tests in this area... I looked at better-sqlite3's implementation - https://github.com/WiseLibs/better-sqlite3/blob/master/lib/methods/transaction.js
- Loading branch information
I think that if we wanted to be super pedantic about it, the
BEGIN TRANSACTION
should be above thetry
, since if that statement throws an exception no transaction should be active