Fix extra state tab when exporting testcase tiddlers #8443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
btheado
reviewed
Jul 29, 2024
pmario
reviewed
Jul 29, 2024
| @@ -72,7 +72,7 @@ code-body: yes | |||
| <%endif%> | |||
| <div class="tc-test-case-panes"> | |||
| <div class="tc-test-case-source"> | |||
| <$macrocall $name="tabs" tabsList="[all[tiddlers]sort[]] -[prefix[$:/state/]] -Description -Narrative -Output Output +[putfirst[]] -[has[plugin-type]]" state=<<state>> default="Output" template="$:/core/ui/testcases/DefaultTemplate/SourceTabs"/> | |||
| <$macrocall $name="tabs" tabsList="[all[tiddlers]sort[]] -[prefix<state>] -[prefix[$:/state/popup/export]] -Description -Narrative -Output Output +[putfirst[]] -[has[plugin-type]]" state=<<state>> default="Output" template="$:/core/ui/testcases/DefaultTemplate/SourceTabs"/> | |||
There was a problem hiding this comment.
Since we are at it, I think we should also move the strange construction -Output Output +[putfirst[]] to the "front" of the filter string like so:
[all[tiddlers]sort[]] Output +[putfirst[]] which allows us to remove the -Output from the filter string.
@Jermolene -- what do you think?
|
Since #8514 has been merged, this PR can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the apperance of extra state tab when exporting testcase tiddlers.