Show wikitext formatting buttons for compound tiddlers #8449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ki]] which is very permissive
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
|
Screenshot with 2 new
|
|
Thanks @pmario |
pmario
deleted the
show-wikitext-formatting-buttons-for-compound-tiddlers
branch
tsukasa-au
pushed a commit
to tsukasa-au/TiddlyWiki5
that referenced
this pull request
Aug 3, 2024
* allow wikitext formatting buttons for types [prefix[text/vnd.tiddlywiki]] which is very permissive * add 2 missing buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8448: [BUG] type: text/vnd.tiddlywiki-multiple - tiddlers only show the basic buttons
...prefix[text/vnd.tiddlywiki]]instead of an exact match, which is relatively permissiveI did use a prefix for the button-condition, because I think every type prefixed with
text/vnd.tiddlywikishould be allowed to use TW wikitext syntax. IMO that's the whole point of this type. -- But I'm open to change it to an exact match@Jermolene -- What do you think?