Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vnd.tiddlywiki-multiple to the editor type dropdown #8450

Conversation

pmario
Copy link
Member

@pmario pmario commented Jul 29, 2024

  • This PR adds vnd.tiddlywiki-multiple to the editor type dropdown, because I can not remember the exact name. Having it in the dropdown makes it easy.

  • It also contains the German version + a fix to make the text shorter

image

Copy link

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Hi @pmario I understand the motivation, but I worry that it makes the dropdown harder to use for most everyday users. Arguably there are already too many entries (for example, image/x-icon is not very useful, and text/x-tiddlywiki should be moved into the classic tools plugin).

So, I'd be happy to proceed as long as we remove/move the two items I mentioned, and then place text/vnd.tiddlywiki-multiple in the "Developer" section of the dropdown.

@Jermolene
Copy link
Member

Thanks @pmario

@Jermolene Jermolene merged commit 8735d1a into TiddlyWiki:master Jul 29, 2024
3 checks passed
@pmario pmario deleted the add-vnd-tiddlywiki-multiple-to-type-dropdown branch July 30, 2024 08:08
tsukasa-au pushed a commit to tsukasa-au/TiddlyWiki5 that referenced this pull request Aug 3, 2024
)

* add text/vnd.tiddlywiki-multiple to editor type dropdown

* de-DE add text/vnd.tiddlywiki-multiple to editor type dropdown

* move text/x-tiddlywiki to classictools plugin

* remove image/x-icon from all languages files

* move type text/vnd.tiddlywiki-multiple to Developer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants