Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view template for normal compound tiddlers #8451

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Leilei332
Copy link
Contributor

This PR implements a basic view template for tiddlers without the $:/tags/wiki-test-spec but has type text/vnd.tiddlywiki-multiple.

It has a tab showing its tiddlers, a table showing the tiddlers' fields and displays its rendered text in the bottom.

图片

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@pmario
Copy link
Member

pmario commented Jul 31, 2024

You are right, the standard wikitext-view is suboptimal. But I'm not really sure, if it should be shown as an interactive table, because it's does hide way to much information.

I personally would prefer a text/plain view, because it shows all the information at once.

image

@Jermolene
Copy link
Member

Thank you @Leilei332 @pmario. The idea of a custom view template for compound tiddlers does make a lot of sense.

To @pmario's point about the value of showing the plain text, one issue is that there can be fields in the compound tiddler that affect how the text is interpreted (eg the new field for importing other compound tiddlers).

Given the complexity of the inheritance arrangements, I think there is real value in being able to see exactly what tiddlers are derived from a given compound tiddler.

I think the tabbed layout is problematic because it requires too much clicking to get an overview.

I prefer the idea of a tabbed display. The default tab would be labelled "Tiddlers" and contain a listing of the tiddlers derived from the compound tiddler. The second tab would be labelled "Source" and would contain the text of the tiddler, but with a table at the top with the relevant fields pulled out.

One reservation about that approach is that it would involve a handful of new translatable strings, perhaps adding disproportionately to the size of the core.

@Jermolene
Copy link
Member

Hi @Leilei332 we need to decide how to proceed with this. I am not against the idea of a friendly template, my only concern is that we shouldn't hide information that is present in the raw text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants