Fix social media preview url tiddler name #8496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The control panel name and the name in the template don't match. I figured the shorter name is better, but let me know if you like the longer name. This is a small fix for recently merged PR TiddlyWiki#8441.
|
Confirmed: simonbaird has already signed the Contributor License Agreement (see contributing.md) |
|
I think the shorter name matches better with the lingo file entries also. |
|
Attn @pmario @Jermolene this one should be an easy merge. |
simonbaird
commented
Aug 13, 2024
|
|
||
| <!-- Twitter Meta Tags --> | ||
| <<meta-plain "twitter:card" "summary_large_image">> | ||
| <<meta-plain "twitter:domain" "$:/SiteDomain" "property">> | ||
| <<meta-plain "twitter:url" "$:/SiteUrl" "property">> | ||
| <<meta-wikified "twitter:title" "$:/SiteTitle">> | ||
| <<meta-wikified "twitter:description" "$:/SiteSubtitle">> | ||
| <<meta-plain "twitter:image" "$:/SitePreviewImageUrl">> | ||
| <<meta-plain "twitter:image" "$:/SitePreviewUrl">> |
There was a problem hiding this comment.
simonbaird
added a commit
to tiddlyhost/tiddlyhost-com
that referenced
this pull request
Aug 20, 2024
Temporary until TiddlyWiki/TiddlyWiki5#8496 is merged. (I'm impatient to try it out in a prerelease TiddlyWiki build.)
|
@Jermolene IMO this small fix can be merged now. |
|
Thank you @simonbaird apologies for the delay |
|
Cool, thanks. FYI there's still a little bug with the whitespace in the meta tags, see my comment in #8441 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The control panel name and the name in the template don't match. I figured the shorter name is better, but let me know if you like the longer name.
This is a small fix for recently merged PR #8441.