-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language plugin: add en-PH (English (PH)) as a new translation #8669
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@techmagus It appears that this is your first contribution to the project, welcome. With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @techmagus I think this looks good. I notice a few of the strings present in the translation appear to be unmodified from the underlying en-GB translation. That's not necessarily a problem but may make it harder for you to track subsequent updates to the en-GB tiddlers.
I also noticed that you expanded on the definition of CamelCase. From a programming language perspective I understand the distinction, but CamelCase is the common term in the wiki community, and for what it's worth Wikipedia says that the case of the initial letter doesn't matter
…ad of regular dash
…m and en dashes); upd: CamelCase instead of separating camelCase and PascalCase (see TiddlyWiki#8669 (review) )
upd: natural DateFormat (instead of formal format)
…s on the reader (ie. a 'dot html' extension vs an 'html' extension)
Oh, those are the em and en dashes. Hmm… you are correct, it's going to be harder, I removed almost all of the em/en/regular dash style changes. ^_^
I see. Yes, I was thinking on being precise on it, but you're right, outside of programming it refers to both. Thank you for the insight. 🙇🏽 Thank you again! |
techmagus has signed the Contributor License Agreement (see contributing.md) |
Thanks @techmagus feel free to follow up with further PRs. |
A small fix for two problems introduced TiddlyWiki#8669. * Two tab should be used to indent instead of four spaces in `tiddlywiki.info` in full edition. * Changed description for `en-PH`. Since "PH" isn't a country name like "US", it should be "Philippines".
A small fix for two problems introduced #8669. * Two tab should be used to indent instead of four spaces in `tiddlywiki.info` in full edition. * Changed description for `en-PH`. Since "PH" isn't a country name like "US", it should be "Philippines".
This update introduces a new translation variant: Philippine English.
Philippine English is a blend of American, Australian, and British English, influenced by local languages and culture. The aim of this translation is twofold: