Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix font links in storybook #205

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

juanchigallego
Copy link
Contributor

Type

  • Bugfix πŸ›
  • New feature 🌈
  • Change request πŸ€“
  • Documentation πŸ“š
  • Tech debt πŸ‘©β€πŸ’»

Changes proposed βœ”οΈ

  • Fix fonts implementation in Storybook

Copy link

Getting started

Please make sure you read our documentation on how to write code for components, stories and styles.

  • Provide a list of changes
  • Include images to help better visualize your work
  • If your PR closes an issue, please link it
  • Add reviewers
  • Add a label to help better understand what your changes are related to

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (d0c4d23) 99.36% compared to head (89d0054) 99.36%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         288      288           
  Lines        1904     1904           
  Branches      276      276           
=======================================
  Hits         1892     1892           
  Misses         11       11           
  Partials        1        1           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@juanchigallego juanchigallego merged commit b4ca61d into master Nov 14, 2023
6 checks passed
@juanchigallego juanchigallego deleted the fix/storybook-fonts branch November 14, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants