-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nix flake and .devcontainer.json #594
base: main
Are you sure you want to change the base?
Conversation
This fixes an issue with the ESLint server within the dev container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't quite work first try, but restarting VSCode twice it seems to now work. No config needed.
First try failed during initializing devcontainer, but automatically prompted to retry
Second try it didn't find node or pnpm and couldn't start the dev server, didn't prompt a restart and I did it manually
Third try pnpm dev
worked fine and everything seems to work
Nix Node version is a bit behind what we have in pkg.json and it gives a warning, but doesn't seem to break anything.
Should we also add some of the tasks to VSCode config? For dev, lint etc 🤔 Though it might be a good idea to still force using the terminal for learning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There also seems to be some trouble loading the tsserver from the workspace. It doesn't have typescript in node_modules 👀
The second problem not finding node or pnpm seems to be a sort of race condition, second time I rebuilt the devcontainer it worked simply after waiting a few seconds
Tasks could be a good idea, I also considered using devenv processes to start the db and |
793484b
to
f505882
Compare
There's a race condition with the ESLint extension and loading Node.js in the devcontainer atm. Node doesn't exist when eslint extension is trying to access it, and it doesn't seem to work even with restarts |
This is something that should be handled by the |
Description
Before submitting the PR, please make sure you do the following
Formatting and linting
pnpm format
and lint the project withpnpm lint