Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HISTORY for release 0.32.0 against TileDB 2.26.0 and replace dump() calls with operator<< #1975

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented May 20, 2024

Following this: TileDB-Inc/TileDB#5026 dump() functions are not anymore available on core library. This PR replaces those calls with operator<<.

@kounelisagis kounelisagis requested review from ihnorton and nguyenv May 20, 2024 14:47
@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from 7f6bbd7 to 4176aec Compare May 28, 2024 13:11
@kounelisagis kounelisagis requested a review from nguyenv May 28, 2024 13:19
@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from 269a01d to e36eeab Compare July 9, 2024 22:14
@kounelisagis kounelisagis changed the title Fix schema.dump() so that it prints out consistently in notebooks [2.25.0] Replace dump() calls with operator<< Jul 9, 2024
@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from cb64087 to 15b1061 Compare July 11, 2024 13:43
@johnkerl
Copy link
Contributor

@kounelisagis thanks for the PR!

Good code, wrong title I think -- ? This isn't 2.25.0, it's dev; and this is about restoring the dump() calls to use the new operator << ...

@kounelisagis
Copy link
Member Author

kounelisagis commented Jul 11, 2024

@kounelisagis thanks for the PR!

Good code, wrong title I think -- ? This isn't 2.25.0, it's dev; and this is about restoring the dump() calls to use the new operator << ...

You are right, I am trying to figure out. In any case, this is not finalized yet and I should wait for TileDB-Inc/TileDB#5179 to be merged. Both title and description should change.

@kounelisagis kounelisagis changed the title [2.25.0] Replace dump() calls with operator<< [2.26] Replace dump() calls with operator<< Jul 24, 2024
@kounelisagis kounelisagis changed the title [2.26] Replace dump() calls with operator<< Replace dump() calls with operator<< Aug 16, 2024
Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kounelisagis
Copy link
Member Author

Reminder for myself to:

  • squash all the commits to two; one for version bump and one for the rest
  • merge without squashing those two

@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from c62edf0 to 814b25b Compare September 10, 2024 10:03
@kounelisagis kounelisagis changed the title Replace dump() calls with operator<< Update HISTORY for release 0.32.0 against TileDB 2.26.0 and replace dump() calls with operator<< Sep 10, 2024
@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from 814b25b to ec9c022 Compare September 10, 2024 23:45
@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from ec9c022 to c94d771 Compare September 10, 2024 23:46
@kounelisagis kounelisagis force-pushed the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch from c94d771 to 02f170e Compare September 10, 2024 23:59
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@kounelisagis kounelisagis merged commit ce8310e into dev Sep 11, 2024
33 checks passed
@kounelisagis kounelisagis deleted the agis/sc-32959/schema-dump-does-not-print-out-consistently-in-notebook branch September 11, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants