Make default value for vfs.s3.region in test conditional
#2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
approved these changes
Oct 14, 2024
kounelisagis
force-pushed
the
agis/aws-default-region
branch
from
3e5eed3
to
4ee4d44
Compare
kounelisagis
changed the title
vfs.s3.regionvfs.s3.region in test conditional
kounelisagis
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following TileDB-Inc/TileDB#5317, the default value of
vfs.s3.regionhas been changed to empty. This change allows AWS to select the default region from sources such as environment variables, profile configuration, and instance metadata.This PR modifies some assertions that check the default value of
vfs.s3.regionwhen related environment variables are present.Should fix the related error in TileDB-Inc/centralized-tiledb-nightlies#24
cc @jdblischak