Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate hacky use of timestamps and time.sleep in tests #2120

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

kounelisagis
Copy link
Member

In #1953, some tests were modified to ensure that TileDB-Inc/TileDB#4800 worked as intended. Previously, the timestamp argument was occasionally used for writes to avoid failures when writes occurred almost concurrently. Following that change, some tests were made temporarily conditional for error identification purposes. Over the subsequent eight months, no related test failures have remained unresolved. The only directly connected issue identified and solved during this time is #2090.

This PR removes the use of the timestamp argument where it was employed in a hacky manner and eliminates the use of time.sleep. However, not all parameterization introduced in #1953 have been reverted, as the use of use_timestamps parameter increases test coverage for scenarios where users want to utilize the time-travel capabilities provided by TileDB.

@kounelisagis kounelisagis merged commit c8c687a into dev Dec 11, 2024
33 checks passed
@kounelisagis kounelisagis deleted the agis/use_timestamps branch December 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants