Eliminate hacky use of timestamps and time.sleep
in tests
#2120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1953, some tests were modified to ensure that TileDB-Inc/TileDB#4800 worked as intended. Previously, the
timestamp
argument was occasionally used for writes to avoid failures when writes occurred almost concurrently. Following that change, some tests were made temporarily conditional for error identification purposes. Over the subsequent eight months, no related test failures have remained unresolved. The only directly connected issue identified and solved during this time is #2090.This PR removes the use of the
timestamp
argument where it was employed in a hacky manner and eliminates the use oftime.sleep
. However, not all parameterization introduced in #1953 have been reverted, as the use ofuse_timestamps
parameter increases test coverage for scenarios where users want to utilize the time-travel capabilities provided by TileDB.