Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish pybind11 conversion #2123

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Finish pybind11 conversion #2123

merged 8 commits into from
Dec 20, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Dec 13, 2024 •
edited
Loading

This PR merges the pybind11 branch into dev, removing the dependency on Cython.

Benchmarks (in seconds):

Metric Before Merge (dev branch) After Merge (pybind11-full) Percentage Difference
Real 81.74 avg 84.28 avg +3.11%
User 64.91 avg 67.15 avg +3.45%
Sys 56.40 avg 58.25 avg +3.28%

[sc-59525]

kounelisagis and others added 8 commits December 9, 2024 10:28
@kounelisagis @nguyenv @teo-tsirpanis
Move Array to pure Python (#2076)
aa99597 
Co-authored-by: nguyenv <vivian@tiledb.com>
Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com>
@kounelisagis
Move _setitem_impl_sparse to Python (#2092)
cc4eb79
@kounelisagis
Merge Metadata and GroupMetadata into one Python class (#2099)
f562df6 
* Delete Cython
* Add new pybind11 Adapter class
* Move Python class + fixes
* Fix tests
@kounelisagis
Move Query to pure Python (#2106)
88e5075 
* Move Query to pure Python
* Add type hints, add docstring, improve code clarity
@kounelisagis
Remove indexing.pyx (#2108)
16b5827 
* Remove Cython `indexing.pyx`
* Fix tests
@kounelisagis @nguyenv
Factor write_direct_dense out of Cython (#2109)
20dbe50 
Co-authored-by: nguyenv <vivian@tiledb.com>
@kounelisagis
Factor _write_array out of Cython (#2115)
5b8cf68
@kounelisagis
Remove Cython Dependency (#2118)
3bd7281 
* Move version method to pybind11
* Delete libtiledb.pyx, libtiledb.pxd, and common.pxi
* Add __iter__ for FragmentsInfoIterator
@kounelisagis kounelisagis marked this pull request as ready for review December 18, 2024 13:47
nguyenv
nguyenv approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work! So great to see everything in Pybind11 now.

@johnkerl
Copy link
Contributor

+1 on that -- thank you @kounelisagis !! 😎

ihnorton
ihnorton approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kounelisagis kounelisagis merged commit a7e060b into dev Dec 20, 2024
33 checks passed
@kounelisagis kounelisagis deleted the pybind11-full branch December 20, 2024 06:22
@kounelisagis kounelisagis mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@nguyenv nguyenv nguyenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kounelisagis @johnkerl @ihnorton @nguyenv