Skip to content

Commit

Permalink
Fix windows issue
Browse files Browse the repository at this point in the history
  • Loading branch information
kounelisagis committed Jul 11, 2024
1 parent 9bb1de7 commit fa37615
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
3 changes: 1 addition & 2 deletions tiledb/api/c_api/attribute/test/unit_capi_attribute.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include "../../../c_api_test_support/testsupport_capi_datatype.h"
#include "../../filter_list/filter_list_api_internal.h"
#include "../attribute_api_external.h"

using namespace tiledb::api::test_support;

TEST_CASE(
Expand Down Expand Up @@ -366,14 +367,12 @@ TEST_CASE(
tiledb_string_t* tdb_string;
capi_return_t rc =
tiledb_attribute_dump_str(nullptr, attr.attribute, &tdb_string);
tiledb_string_free(&tdb_string);
REQUIRE(tiledb_status(rc) == TILEDB_INVALID_CONTEXT);
}
SECTION("null dimension") {
tiledb_string_t* tdb_string;
capi_return_t rc =
tiledb_attribute_dump_str(attr.context(), nullptr, &tdb_string);
tiledb_string_free(&tdb_string);
REQUIRE(tiledb_status(rc) == TILEDB_ERR);
}
// SECTION("null file pointer") `nullptr` is allowed; it's mapped to `stdout`
Expand Down
3 changes: 1 addition & 2 deletions tiledb/api/c_api/dimension/test/unit_capi_dimension.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#include "../../../c_api_test_support/testsupport_capi_datatype.h"
#include "../../filter_list/filter_list_api_internal.h"
#include "../dimension_api_internal.h"

using namespace tiledb::api::test_support;

TEST_CASE(
Expand Down Expand Up @@ -344,14 +345,12 @@ TEST_CASE(
tiledb_string_t* tdb_string;
capi_return_t rc =
tiledb_dimension_dump_str(nullptr, dim.dimension, &tdb_string);
tiledb_string_free(&tdb_string);
REQUIRE(tiledb_status(rc) == TILEDB_INVALID_CONTEXT);
}
SECTION("null dimension") {
tiledb_string_t* tdb_string;
capi_return_t rc =
tiledb_dimension_dump_str(dim.ctx.context, nullptr, &tdb_string);
tiledb_string_free(&tdb_string);
REQUIRE(tiledb_status(rc) == TILEDB_ERR);
}
// SECTION("null file pointer") `nullptr` is allowed; it's mapped to `stdout`
Expand Down
3 changes: 0 additions & 3 deletions tiledb/api/c_api/domain/test/unit_capi_domain.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
*/
#define CATCH_CONFIG_MAIN
#include <test/support/tdb_catch.h>

#include "../../../c_api_test_support/testsupport_capi_context.h"
#include "../domain_api_external.h"
#include "../domain_api_internal.h"
Expand Down Expand Up @@ -249,13 +248,11 @@ TEST_CASE("C API: tiledb_domain_dump argument validation", "[capi][domain]") {
SECTION("null context") {
tiledb_string_t* tdb_string;
auto rc{tiledb_domain_dump_str(nullptr, dom.domain, &tdb_string)};
tiledb_string_free(&tdb_string);
CHECK(rc == TILEDB_INVALID_CONTEXT);
}
SECTION("null domain") {
tiledb_string_t* tdb_string;
auto rc{tiledb_domain_dump_str(ctx, nullptr, &tdb_string)};
tiledb_string_free(&tdb_string);
CHECK(rc == TILEDB_ERR);
}
// SECTION("null FILE") is omitted. Null FILE* defaults to stderr
Expand Down

0 comments on commit fa37615

Please sign in to comment.