-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove serialization non C41 constructors from stats #4706
Conversation
With this change in, PR #4685 and others to follow should: a) remove Subarray::set_stats and respective call from serialization/query.cc b) where Subarray is constructed in serialization/query.cc, change constructor call with the following code snippet: auto &stats_data = stats_from_capnp(reader.getStats()); Subarray subarray(array, layout, query_stats, stats_data, dummy_logger, true); c) The constructor calls parent_stats->create_child(prefix, stats_data); d) When all migrations are done, make Stats::populate_with_data private
This pull request has been linked to Shortcut Story #40316: Remove serialization non C.41 constructors from stats.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, let's try to make the stats() accessors of all class return a const Stats& object. Let's also validate that the stats we get from REST are identical before and after this change.
Manually tested this in a local REST server and stats are identical before and after the change. |
With this change in, PR #4685 and others to follow should:
a) remove
Subarray::set_stats
and respective call fromserialization/query.cc
b) whereSubarray is constructed in
serialization/query.cc`, change constructor call with the following code snippet:c) The constructor calls parent_stats->create_child(prefix, stats_data); d) When all migrations are done, make
Stats::populate_with_data private
TYPE: NO_HISTORY
DESC: Remove serialization non C41 constructors from stats