Deprecate C++ APIs that rely on deprecated APIs. #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiterLuc
approved these changes
Apr 15, 2024
teo-tsirpanis
changed the title
Query::submit_async C++ API.
|
Updated PR to deprecate all C++ APIs that use deprecated APIs under the hood. |
KiterLuc
approved these changes
Apr 22, 2024
KiterLuc
pushed a commit
that referenced
this pull request
Apr 29, 2024
…++ APIs. (#4887) [SC-23937](https://app.shortcut.com/tiledb-inc/story/23937/build-artifact-disabling-deprecated-functions) > [!NOTE] > Depends on #4879. As part of preparing to remove the deprecated APIs, we need a mechanism to exclude them from being compiled. There exists already the `TILEDB_REMOVE_DEPRECATIONS` option, but it covers only a subset of the deprecated APIs in the C++ `Array` class. This PR expands `TILEDB_REMOVE_DEPRECATIONS` to cover every deprecated C and C++ API. When this option is set, a define with the same name is defined and the deprecated APIs are not compiled into the library. This flag also gets publicly exported from the `TileDB::tiledb` target. --- TYPE: BUILD DESC: Update the `TILEDB_REMOVE_DEPRECATIONS` option to exclude all deprecated C and C++ APIs from the library binary and the headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of removing the deprecated APIs, we discovered that there are some non-deprecated C++ APIs that are calling deprecated C APIs and would break once the latter get removed. This PR marks these C++ APIs as deprecated, to be removed alongside the C APIs.
TYPE: CPP_API
DESC:
Query::submit_asyncis deprecated. CallQuery::submit()on another thread instead.TYPE: CPP_API
DESC: Overloads of methods and constructors in
ArrayandArraySchemathat accept encryption keys are deprecated. Specify the encryption key with thesm.encryption_typeandsm.encryption_keyconfig options instead.