Make closing a group that is not open a no-op #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported from Cloud team: When attempting to close a TileDB group that is not open an error is raised polluting the server log. On the other hand, attempting to close a TileDB Array does not result to any error log (as per #2889).
This PR unifies the behavior between closing and Array and a Group. Another solution would have been to check if the group is open on the server side but this would mean special casing for Groups, when I don't see the benefit of it.
[sc-46186]
TYPE: IMPROVEMENT
DESC: Make closing a group that is not open a no-op