Implement consolidation memory budget variables. #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implement 3 new variables for memory budgetting for consolidation. The values are a set of 3 weights that weigh each parts of the consolidation algorithm. The buffers, the read operation and the write operation. All weights are summed and ratios are computed to divide sm.mem.total_budget. The values are: * `sm.mem.consolidation.buffers_weight` * `sm.mem.consolidation.reader_weight` * `sm.mem.consolidation.writer_weight` --- TYPE: IMPROVEMENT DESC: Implement consolidation memory budget variables.
teo-tsirpanis
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement 3 new variables for memory budgetting for consolidation. The values are a set of 3 weights that weigh each parts of the consolidation algorithm. The buffers, the read operation and the write operation. All weights are summed and ratios are computed to divide sm.mem.total_budget. The values are:
sm.mem.consolidation.buffers_weightsm.mem.consolidation.reader_weightsm.mem.consolidation.writer_weightNote this also removes the total_buffer_size deprecated setting.
TYPE: CONFIG
DESC: Implement consolidation memory budget variables.