Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug test for REST array schema evolution #5142

Closed
wants to merge 1 commit into from

Conversation

jp-dark
Copy link
Contributor

@jp-dark jp-dark commented Jul 1, 2024

Add REST test for array schema evolution


TYPE: NO_HISTORY

@ypatia
Copy link
Member

ypatia commented Jul 2, 2024

Thanks a lot @jp-dark for that test, it's really useful! I'll look at the underlying defect as soon as I sort out some other priorities.

@johnkerl @jp-dark would you be temporarily unblocked in this scenario if you use Query v3? As you can see in the gitlab runner we don't have that defect if we use rest.use_refactored_array_open_and_query_submit .
I know we have another issue with Qv3 though, and that's the one I am actively working on, but maybe it's worth trying if in this scenario that issue doesn't show up and it can get you running.

@johnkerl
Copy link
Contributor

johnkerl commented Jul 2, 2024

@ypatia my understanding was that query v3 had other issues. Let me check my notes and get back to you.

@ypatia
Copy link
Member

ypatia commented Jul 2, 2024

@ypatia my understanding was that query v3 had other issues. Let me check my notes and get back to you.

yeap, it has this one : https://app.shortcut.com/tiledb-inc/story/48707/502-bad-gateway-on-soma-query-with-rest-use-refactored-array-open-and-query-submit
was just wondering if that's the same use case/scenario.

@johnkerl
Copy link
Contributor

johnkerl commented Jul 2, 2024

was just wondering if that's the same use case/scenario.

@ypatia SC 48707 reports a problem with ingesting (writing) data with

        "rest.use_refactored_array_open": True,
        "rest.use_refactored_array_open_and_query_submit": True,

The issue on this PR with querying (reading) data where the schema has been evolved

@ypatia
Copy link
Member

ypatia commented Jul 3, 2024

@ypatia SC 48707 reports a problem with ingesting (writing) data with

Your repro scripts in SC-48707 seem like read queries to me. Am I missing something? I am actively working on the resolution as a prioirity so I'd really like to know more on that issue.

Did you have the change to try this schema evolution scenario with query v3?

@johnkerl
Copy link
Contributor

johnkerl commented Jul 3, 2024

Your repro scripts in SC-48707 seem like read queries to me. Am I missing something?

You're right, sorry for the confusion -- sc-48707 is indeed a read query.

Did you have the change to try this schema evolution scenario with query v3?

@ypatia thank you -- I'll try this right now over morning coffee.

@johnkerl
Copy link
Contributor

johnkerl commented Jul 3, 2024

(More conversation in Slack BTW.)

@jp-dark jp-dark closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants