Support consolidation with max_frag_size in Dense. #5190
+470
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/sc-50059/try-to-reproduce-data-loss-with-max-fragment
branch
from
2c04878 to
8930bf6
Compare
DimitrisStaratzis
changed the title
DimitrisStaratzis
force-pushed
the
dstara/sc-50059/try-to-reproduce-data-loss-with-max-fragment
branch
from
3486d00 to
0184785
Compare
DimitrisStaratzis
force-pushed
the
dstara/sc-50059/try-to-reproduce-data-loss-with-max-fragment
branch
from
a7d3c56 to
28b7809
Compare
DimitrisStaratzis
force-pushed
the
dstara/sc-50059/try-to-reproduce-data-loss-with-max-fragment
branch
from
28b7809 to
86fd805
Compare
DimitrisStaratzis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables consolidation with the
max_fragment_sizeconfig parameter in Dense arrays. In essnece, a consolidation where if we assume that the array had N fragments it will not end up with N+1 fragments but with N+M where M is the number of new fragments that were produced due to memory size limitations added by the user. (e.g.sm.max_fragment_size)[WIP] add test for negative dims.
TYPE: FEATURE
DESC: Support consolidation with max_frag_size in Dense.
[sc-50059] [sc-49509]