-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #5279
Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #5279
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
@teo-tsirpanis this looks like it broke the back compat tests somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We unfortunately cannot update the actions in the Release workflow until we upgrade manylinux 2014, which will happen in 2.31. See also #4679 (comment).
@@ -66,7 +66,7 @@ jobs: | |||
- uses: actions/checkout@v3 | |||
|
|||
- name: Download a single artifact | |||
uses: actions/download-artifact@v3 | |||
uses: actions/download-artifact@v4.1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails because the upload-artifact
job must be updated as well.
We don't seem to be impacted by this vulnerability; the artifacts we download are uploaded by the same workflow and thus do not cross a trust boundary. |
Closing, the vulnerability in question has been updated to not affect action versions before 4. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps actions/download-artifact from 3 to 4.1.7.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
65a9edc
Merge pull request #325 from bethanyj28/mainfdd1595
licensedc13dba1
update@actions/artifact
dependency0daa75e
Merge pull request #324 from actions/eggyhead/use-artifact-v2.1.69c19ed7
Merge branch 'main' into eggyhead/use-artifact-v2.1.63d3ea87
updating license89af5db
updating artifact package v2.1.6b4aefff
Merge pull request #323 from actions/eggyhead/update-artifact-v2158caf195
package lock updated7a2ec4
updating package versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.