Add SC-54468 min/max regression test cases: min/max cannot return a NULL result on a non-nullable attribute, even when appropriate #5282
+249
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
force-pushed
the
rr/sc-54468-regression-test
branch
from
567b0eb to
f6ffd29
Compare
bekadavis9
approved these changes
Oct 15, 2024
| // Data | ||
| std::vector<uint64_t> x = {1, 2, 3, 4, 5, 6, 7, 8}; | ||
| std::vector<uint64_t> atts = {10, 20, 30, 40, 50, 60, 70, 80}; | ||
|
|
| return std::make_pair(maybe_min, maybe_max); | ||
| } | ||
|
|
||
| bool array_exists(Context& ctx, const char* uri); |
There was a problem hiding this comment.
This seems to be unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with adding aggregate functions to
tiledb-rsI observed that the min and max aggregate operations return 0 when the array is empty.In SQL, the min and max aggregate functions are expected to return NULL when there are no non-NULL inputs. While we are not SQL, I do believe it is important to be compliant with this expectation:
We should improve the behavior so that min/max functions can always return NULL. This PR adds regression tests demonstrating that we can't or don't do this..
TYPE: BUG
DESC: add regression test demonstrating problems with non-nullable min/max result