Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtools40 build #5326

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix rtools40 build #5326

merged 1 commit into from
Sep 30, 2024

Conversation

ihnorton
Copy link
Member

Try to fix rtools40 build.


TYPE: NO_HISTORY
DESC: Try to fix rtools40 build.

@ihnorton ihnorton marked this pull request as ready for review September 30, 2024 19:14
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a comment? microsoft/vcpkg#41199 (comment)

@ihnorton ihnorton merged commit c0fce06 into dev Sep 30, 2024
64 checks passed
@ihnorton ihnorton deleted the ihn/sc-56545/fix-rtools-build branch September 30, 2024 19:30
@ihnorton
Copy link
Member Author

ihnorton commented Sep 30, 2024

/backport to release-2.26

@ihnorton
Copy link
Member Author

ihnorton commented Sep 30, 2024

Added comment and x-ref to merged commit.

@ihnorton ihnorton changed the title Try to fix rtools40 build Fix rtools40 build Sep 30, 2024
@teo-tsirpanis
Copy link
Member

/backport to release-2.26

Copy link
Contributor

Started backporting to release-2.26: https://github.com/TileDB-Inc/TileDB/actions/runs/11115138384

ihnorton added a commit that referenced this pull request Oct 1, 2024
Backport of #5326 to release-2.26

---
TYPE: NO_HISTORY
DESC: [Backport release-2.26] Fix rtools40 build (#5326) (#5328)

Co-authored-by: Isaiah Norton <isaiah@tiledb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants