Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C.41 compliance: GCS factory constructor. #5393

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

C.41 compliance: GCS factory constructor. #5393

wants to merge 5 commits into from
+473 −685

Conversation

bekadavis9
Copy link
Contributor

Remove GCS::init in favor of a C.41-compliant factory constructor. Use struct GCSParameters to store GCS-specific configuration parameters. Remove Status_GCSError, and replace call sites with throws of GCSException.

[sc-60072]

TYPE: IMPROVEMENT
DESC: C.41 constructor: GCS

@bekadavis9 bekadavis9 requested a review from a team as a code owner December 2, 2024 18:55
teo-tsirpanis
teo-tsirpanis reviewed Dec 10, 2024
View reviewed changes
tiledb/api/c_api/config/config_api_external.h Show resolved Hide resolved
tiledb/sm/cpp_api/config.h Show resolved Hide resolved
tiledb/sm/filesystem/gcs.cc Outdated Show resolved Hide resolved
teo-tsirpanis
teo-tsirpanis approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvigilante nickvigilante nickvigilante left review comments

@teo-tsirpanis teo-tsirpanis teo-tsirpanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekadavis9 @teo-tsirpanis @nickvigilante